Skip to content

refactor: update blas/ext/base/dssumpw to follow current project conventions #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2024
Merged

refactor: update blas/ext/base/dssumpw to follow current project conventions #1999

merged 7 commits into from
Apr 15, 2024

Conversation

soumajit23
Copy link
Contributor

@soumajit23 soumajit23 commented Mar 22, 2024 •
edited
Loading

Resolves # 1503

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 22, 2024
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/dssumpw to follow current project conventions refactor: update blas/ext/base/dssumpw to follow current project conventions Mar 23, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 23, 2024
kgryte
kgryte reviewed Mar 23, 2024
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/dssumpw/src/addon.c Outdated
STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 4 );
c_saxpy( N, alpha, X, strideX, Y, strideY );
Copy link
Member

@kgryte kgryte Mar 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is incorrect. See the addon.cpp file and update accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated addon.c file as instructed. Please review. Thanks!

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 23, 2024
@soumajit23 soumajit23 requested a review from kgryte March 25, 2024 12:46
@soumajit23 soumajit23 mentioned this pull request Mar 28, 2024
Closed
6 tasks
@soumajit23
refactor: update addon.c
7ea57c6 
Signed-off-by: Soumajit Chatterjee <121816890+soumajit23@users.noreply.github.com>
@soumajit23
refactor: update manifest.json
fee5594 
Signed-off-by: Soumajit Chatterjee <121816890+soumajit23@users.noreply.github.com>
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
@Planeshifter
chore: revert copyright year changes
2090b01 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter reviewed Mar 29, 2024
View reviewed changes
@Planeshifter
chore: fix error in committed review suggestions
586be1d 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@soumajit23
Copy link
Contributor Author

@Planeshifter are there any more changes that are required?
If not, please merge this PR since I plan on applying for GSoC, and a merged PR is required to meet the patch requirements.
Thanks!

@kgryte
Copy link
Member

kgryte commented Apr 8, 2024

@soumajit23 Looks like CI is failing for this PR. Until test and benchmark failures are addressed, this PR won't be able to move forward.

@Planeshifter Planeshifter self-requested a review April 15, 2024 01:26
@Planeshifter Planeshifter merged commit 87c4933 into stdlib-js:develop Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dssumpw to follow current project conventions
4 participants
@soumajit23 @kgryte @Planeshifter @stdlib-bot